Markus Elfring

[An extra null pointer check is not needed in functions](https://stackoverflow.com/questions/18775608/free-a-null-pointer-anyway-or-check-first "Free a null pointer anyway or check first?") like the following. - [get_format](https://github.com/michaelrsweet/htmldoc/blob/f16285c92c5aa12fd4aaac72c9417fd09ad603dc/htmldoc/util.cxx#L245 "get_format function") - [httpClearCookie](https://github.com/michaelrsweet/htmldoc/blob/41cca81f5cfbd507fe4f43c7c6a3c6c72e16e50a/htmldoc/http.c#L276 "httpClearCookie function")

:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly....

Increase the usage of augmented assignment statements

4

:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly....

:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly....

Convert five statements to augmented assignments

23

Source code like “`var = var + `…” was specified at some places so far. Please [use augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Description for augmented assignment statements") instead because they are succinct...

:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly....

I expect that exception handling is usually supported by a C++ program. I wonder why your function “[main](https://github.com/twhuang-uiuc/DtCraft/blob/e81fd03ba9f6d5d44b7663aee3460c237a8fdd6c/main/dtc-agent.cpp#L16 "main() function")” does not contain [corresponding try and catch instructions](https://stackoverflow.com/questions/368184/does-it-make-sense-to-catch-exceptions-in-the-main "Does it...

Increase the usage of augmented assignment statements

4

:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly....

Check return codes everywhere

3

Would you like to add more error handling for return values from functions like the following? - [ftell](http://pubs.opengroup.org/onlinepubs/9699919799/functions/ftell.html) ⇒ [read_file](https://github.com/mypaint/libmypaint/blob/207d21ff41e4842a1f4e0f4f5e19c1dd995a9250/tests/testutils.c#L11) - [malloc](http://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html) ⇒ [mypaint_brush_new](https://github.com/mypaint/libmypaint/blob/556c703c08007132c0f5c8de6b1f0fa66e33f127/mypaint-brush.c#L109)

:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of combined operators](https://perldoc.perl.org/perlop#Assignment-Operators "Description for assignment operators") accordingly....