Markus Elfring
Markus Elfring
I would like to point out that identifiers like “[`_CRAM_SAMTOOLS_H_`](https://github.com/samtools/htslib/blob/5d114ebd8e9b80622769b8e575c5a9359cd51273/cram/cram_samtools.h#L31 "Update candidate")” and “[`_AC_KLIST_H`](https://github.com/samtools/htslib/blob/bf753361dab9b1640cf64f7886dbfe35357a43c5/htslib/klist.h#L26 "Another update candidate")” [do not fit](https://www.securecoding.cert.org/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not use identifiers which are reserved for the compiler...
Would you like to add more error handling for return values from functions like the following? - [fopen](http://pubs.opengroup.org/onlinepubs/9699919799/functions/fopen.html) ⇒ [main](https://github.com/fdb/frequensea/blob/8e6af67da63d80e629875f65f979dcaff93ad302/c/render-text.c#L52) - [printf](http://pubs.opengroup.org/onlinepubs/9699919799/functions/printf.html) ⇒ [receive_sample_block](https://github.com/fdb/frequensea/blob/8e6af67da63d80e629875f65f979dcaff93ad302/c/fft-batch.c#L54)
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of combined operators](https://www.php.net/manual/en/language.operators.assignment.php#language.operators.assignment.arithmetic "Description for assignment operators") accordingly....
I expect that exception handling is usually supported by a C++ program. I wonder why your function “[main](https://github.com/AOT-AG/DicomToMesh/blob/8bcfd40dcad6d7ea1ea2aac50805548238d7bcad/dicom2mesh/src/main.cpp#L26 "main() function")” does not contain [corresponding try and catch instructions](https://stackoverflow.com/questions/368184/does-it-make-sense-to-catch-exceptions-in-the-main "Does it...
Would you like to [replace any double quotes](https://github.com/zdevito/ATen/blob/042188fca556e71d3c042ce44b406652f931dfd7/aten/src/ATen/ATen.h#L3 "Check inclusion style") by [angle brackets around file names for include statements](https://stackoverflow.com/questions/21593/what-is-the-difference-between-include-filename-and-include-filename "What is the difference between #include and #include “filename”?")?
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of compound operators](https://docs.oracle.com/javase/specs/jls/se17/html/jls-15.html#jls-15.26 "Description for assignment operators") accordingly....
Would you like to [add more error handling](https://github.com/s-macke/SAM/blob/bcf92b5c693cbaf25e26c17c1c1b0589b3647489/src/main.c#L15 "Update candidate: WriteWav()") for return values from calls of [a function like fwrite()](https://pubs.opengroup.org/onlinepubs/9699919799/functions/fwrite.html "Binary output")?
Would you like to [wrap any pointer data members](https://github.com/anhttran/extreme_3d_faces/blob/ce8ae8de17e591dd92c656304fe348bc8f7137fa/modules/PoseExpr/src/FImRenderer.cpp#L6 "Update candidate: FImRenderer class") with the class template “[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr "Description for the usage of smart pointers")”?
[An extra null pointer check is not needed](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like in [the function “FImRenderer::loadPLYFile”](https://github.com/anhttran/extreme_3d_faces/blob/ce8ae8de17e591dd92c656304fe348bc8f7137fa/modules/PoseExpr/src/FImRenderer.cpp#L27 "Update candidate").
I guess that a different program design will be needed for [the function “Server::IntHandler”](https://github.com/loveyacper/Qedis/blob/3cc0e4a1ecc48bbc55958559b1953c270ff10b06/QBase/Server.cc#L17 "Reconsider signal handling") because [member functions can be async-signal-unsafe](https://wiki.sei.cmu.edu/confluence/display/cplusplus/MSC54-CPP.+A+signal+handler+must+be+a+plain+old+function "A signal handler must be a plain...