mrsh icon indicating copy to clipboard operation
mrsh copied to clipboard

Allocation error handling

Open elfring opened this issue 6 years ago • 6 comments

Would you like to add more error handling for return values from functions like the following?

elfring avatar Dec 29 '18 19:12 elfring

Yeah, this is a TODO. I'd merge patches to do so. Adding this to the core mrsh library has higher priority than adding it to executables.

emersion avatar Dec 29 '18 19:12 emersion

How do you think about to improve static source code analysis also for this software?

elfring avatar Dec 29 '18 19:12 elfring

What do you mean?

I run Clang's static analyzer from time to time. I'd prefer not to run it for each pull request because it's slow and has false positives. Do you have better ideas?

Related: I also run sanitizers as part of CI: Arch builds run tests with ASan and UBSan enabled.

emersion avatar Dec 29 '18 19:12 emersion

elfring avatar Dec 29 '18 19:12 elfring

No, sorry, I'd prefer to stick with the current style. Readability and KISS first.

emersion avatar Dec 29 '18 19:12 emersion

Could run static analysis on each commit rather than each PR. Would require some builds.sr.ht changes.

ddevault avatar Dec 29 '18 19:12 ddevault