Markus Elfring

Fix signal handler

5

The functions "[ioctl](http://pubs.opengroup.org/onlinepubs/9699919799/functions/ioctl.html)" and "[exit](http://pubs.opengroup.org/onlinepubs/9699919799/functions/exit.html)" do not belong to the list of [async-signal-safe functions](https://www.securecoding.cert.org/confluence/display/seccode/SIG30-C.+Call+only+asynchronous-safe+functions+within+signal+handlers). I guess that a different program design will be needed for your functions "[gpm_winch_hook](https://github.com/telmich/gpm/blob/a4aea32acf410aa01623b0bc214e0f5189a87098/src/lib/liblow.c#L116)" and "[killed](https://github.com/telmich/gpm/blob/a4aea32acf410aa01623b0bc214e0f5189a87098/src/prog/hltest.c#L133)".

Completion of error handling

2

I have looked at a few source files for your current software. I have noticed that [some checks for return codes are missing](http://lists.linux.it/pipermail/gpm/2008-December/001060.html). Would you like to add more error...

Addition of a directory name for header file inclusion

3

[Some header files](https://github.com/Visu4link/pastec/tree/2187deaa96f1812add5388f3cd02e89addfa6e01/include) reuse words like "index", "messages" and "thread" in the file names which might be popular also in other software development areas. I suggest to add your project...

I have looked at a few source files for your current software. I have noticed that some checks for return codes are missing. Would you like to add more error...

I expect that exception handling is usually supported by a C++ program. I wonder why your function "[main](https://github.com/Visu4link/pastec/blob/36b13060f6f9a5e1e328fa1423367226f2e75e3c/src/main.cpp#L49)" does not contain [corresponding try and catch instructions](http://stackoverflow.com/questions/368184/does-it-make-sense-to-catch-exceptions-in-the-main) so far. How do...

Complete build options for Pthread API

1

Would you like to add the configuration script "[AX_PTHREAD](http://www.gnu.org/software/autoconf-archive/ax_pthread.html)" to [your build specification](https://github.com/hyPiRion/c-rrb/blob/b4fe6cb29f444cd72251e94323df9d93d641db6e/configure.ac#L19)?

Completion of error handling

4

Would you like to add more error handling for return values from functions like the following? - [malloc](http://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html "Memory allocation") ⇒ [createLayer](https://github.com/100/Cranium/blob/4c1d028a4f9e897a3f709a6b92cae414eba6ee59/src/layer.h#L56) - [printf](http://pubs.opengroup.org/onlinepubs/9699919799/functions/printf.html "Print formatted output") ⇒ [printMatrix](https://github.com/100/Cranium/blob/7d5c219c9bd62b4a92bda712c374cc786c9be0ed/src/matrix.h#L137)

I would like to point out that an identifier like “[`__fuzzfactory_dsf_max`](https://github.com/rohanpadhye/FuzzFactory/blob/f5e72b71aa8f5e4b702e98699c9df7dba0a8ba8b/include/waypoints.h#L48 "Update candidate")” [does eventually not fit](https://www.securecoding.cert.org/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier "Do not use identifiers which are reserved for the compiler implementation.") to the...

Would you like to [add more error handling](https://github.com/SergiusTheBest/plog/blob/a248b2f9cb0755d6912a5b5e4e402a4921b3e978/include/plog/Util.h#L338 "Update candidate: Mutex constructor") for return values from a function like “[pthread_mutex_init](http://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_mutex_init.html "Initialize a mutex.")”?

:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of compound operators](https://262.ecma-international.org/12.0/#sec-assignment-operators "Description for assignment operators") accordingly....