Markus Elfring
Markus Elfring
I suggest to reuse a higher level build system than [your current small make file](https://github.com/Wikinaut/agrep/blob/ad61ed6add3d86c1c1aff81c0dcfe3326a46fef0/Makefile#L4) so that powerful checks for software features will become easier. - [CMake](http://cmake.org/) - [Autotools](http://www.gnu.org/software/autoconf/#TOCintroduction)
I have looked at a few source files for your current software. I have noticed that some checks for return codes are missing. Would you like to add more error...
I would like to point out that identifiers like "[`_AGREP_H_`](https://github.com/Wikinaut/agrep/blob/ad61ed6add3d86c1c1aff81c0dcfe3326a46fef0/agrep.h#L13)" and "[`_DIRENT`](https://github.com/Wikinaut/agrep/blob/de7e6911634f5ccea8fb38e247ce43515a4cafd0/ntdirent.h#L19)" [do not fit](https://www.securecoding.cert.org/confluence/display/seccode/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29) to the expected naming convention of the C language standard. Would you like to adjust...
[Conditional compilation was introduced for a possible logging software](https://github.com/aesophor/Wmderland/commit/83690cbef0d3067ed350cbe654e71183eba460b5#diff-7ec3c68a81efff79b6ca22ac1f1eabbaR7 "Log interface selection"). This software adjustment had the consequence that preprocessor statements were distributed in the code base. Thus I suggest...
[Software build systems can provide version information](https://cmake.org/cmake-tutorial/ "Adding a version number and configured header file") in a structured way. I suggest to use these data so that [related details like...
[Some if branches contain duplicate code for exception handling](https://github.com/relan/exfat/blob/360084b62eb62b7453a5e9d7e374d67a3ccc0f0d/libexfat/mount.c#L195 "Update candidate: exfat_mount()"). This implementation detail can be improved by [the usage of goto statements](https://wiki.sei.cmu.edu/confluence/display/c/MEM12-C.+Consider+using+a+goto+chain+when+leaving+a+function+on+error+when+using+and+releasing+resources "Consider using a goto chain when...
I would like to point out that an identifier like “[`__unused1`](https://github.com/relan/exfat/blob/0dfb0893ca92190f1480d20a134e8d61272d173c/libexfat/exfatfs.h#L44 "Update candidate")” [does eventually not fit](https://www.securecoding.cert.org/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier "Do not use identifiers which are reserved for the compiler implementation.") to the...
I suggest to reuse a higher level build system than [your current make script](https://github.com/ohler55/perfer/blob/512efcb996f69a1db4fc851d4006655526dea4c5/Makefile#L2 "Update candidate") so that powerful checks for software features will become easier. - [CMake](https://cmake.org/ "Building software...
Would you like to add more error handling for return values from functions like the following? - [malloc](https://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html "Memory allocation") ⇒ [build_req](https://github.com/ohler55/perfer/blob/e0486ec5bf825168886672c848b51fdfe08f8a5f/src/perfer.c#L98) - [pthread_mutex_init](https://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_mutex_init.html "Initialize a mutex.") ⇒ [perfer_init](https://github.com/ohler55/perfer/blob/e0486ec5bf825168886672c848b51fdfe08f8a5f/src/perfer.c#L124)
Would you like to [replace any double quotes](https://github.com/andrewssobral/bgslibrary/blob/98c8d4b8156f9e8f28fe007aa369d1ee567653b6/VideoAnalysis.h#L22) by [angle brackets around file names for include statements](http://stackoverflow.com/questions/21593/what-is-the-difference-between-include-filename-and-include-filename)?