Markus Elfring
Markus Elfring
I suggest to reuse a higher level build system than [your current make file](https://github.com/attie/libxbee3/blob/fb0f4d5f405c6d65ea886b6a21445c3c0606a158/makefile#L1) so that powerful checks for software features will become easier. - [CMake](http://cmake.org/) - [Autotools](http://www.gnu.org/software/autoconf/#TOCintroduction)
I would like to point out that an identifier like "[`__XBEE_PREPARE_H`](https://github.com/attie/libxbee3/blob/09bc0915faf7044dbea79e098822db19e0e58f10/prepare.h#L1)" [does eventually not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29) to the expected naming convention of the C++ language standard. Would you like to adjust...
I would like to point out that an identifier like “[`__CHAFA_TERM_INFO_H__`](https://github.com/hpjansson/chafa/blob/4338ddeb8d0d37c8271ec7e527ec153f3f9026fa/chafa/chafa-term-info.h#L20 "Update candidate")” [does eventually not fit](https://www.securecoding.cert.org/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28IncludeGuard%29 "Do not use identifiers which are reserved for the compiler implementation.") to the...
I would like to point out that an identifier like “[`__GST_SYNC_SERVER_H`](https://github.com/ford-prefect/gst-sync-server/blob/f34f86f98ded448e9638582823c7c95c0a48c4ce/gst-libs/gst/sync-server/sync-server.h#L21 "Update candidate")” [does not fit](https://www.securecoding.cert.org/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28IncludeGuard%29 "Do not use identifiers which are reserved for the compiler implementation.") to the expected...
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of combined operators](https://www.php.net/manual/en/language.operators.assignment.php#language.operators.assignment.arithmetic "Description for assignment operators") accordingly....
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of combined operators](https://perldoc.perl.org/perlop#Assignment-Operators "Description for assignment operators") accordingly....
I would like to point out that an identifier like “[`_CSVPARSER_HPP_`](https://github.com/MyBoon/CSVparser/blob/e5f6214d02731a8c7898d82d2d5ac4b4861fca06/CSVparser.hpp#L1 "Update candidate")” [does eventually not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the compiler implementation.") to...
[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [DecisionTree](https://github.com/JakobEngel/dso/blob/f6e43e277a8e6f606265c1d90fd7549e475e6ea6/src/OptimizationBackend/AccumulatedSCHessian.h#L54 "Destructor for DecisionTree") - [OSCArgument::clearBlobData](https://github.com/nickgillian/grt/blob/a6b7196c19debbbb76498a462f63ba73c1801f07/gui/GRT/OSC/OSCMessage.h#L56...
Would you like to add more error handling for return values from functions like the following? - [fwrite](https://pubs.opengroup.org/onlinepubs/9699919799/functions/fwrite.html "Binary output") ⇒ [ucl_file_append_len](https://github.com/vstakhov/libucl/blob/c078d8bb804f9f7f62aa7d17960c1ac5ac75ddec/src/ucl_emitter_utils.c#L288) - [malloc](https://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html "Memory allocation") ⇒ [ucl_priority_handler](https://github.com/vstakhov/libucl/blob/2e528a28b41e47a1f9c6e8506d52a00fb3ef457d/src/ucl_util.c#L1718)
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of compound operators](https://docs.oracle.com/javase/specs/jls/se17/html/jls-15.html#jls-15.26 "Description for assignment operators") accordingly....