kit
kit copied to clipboard
[chore] upgrade to playwright 1.28.1
let's see if the latest version works...
Issue from 1.28.0 was fixed: https://github.com/microsoft/playwright/issues/18865
🦋 Changeset detected
Latest commit: 5b49be8c8b75574b151d49059f5ad3ea3a3668ee
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
Name | Type |
---|---|
create-svelte | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
triggered a rerun on the mac fail
Same failure as https://github.com/sveltejs/kit/pull/7435:
@sveltejs/kit:test: 1 failed @sveltejs/kit:test: [webkit-dev] › test/client.test.js:610:3 › Load › using window.fetch causes a warning ==========
It seems the webkit version has not been able to capture the console logs
IIRC, the stack trace check in fetcher.js
was written that way so as to avoid giving false positives for the warning when a fetch
happened to be called when a load
was running but was not actually called by that load
. Do we really need to lose that heuristic? Have you ever observed that fail when running an app for real, or just in the tests? If at all possible, I'd much rather have imperfect tests than a flawed feature that we can more easily test.
Thanks. I updated it to keep the stack trace and added a comment explaining what it's doing. It appears to be passing still