Damien Grisonnet

Results 522 comments of Damien Grisonnet

It should be good now, I hadn't tested it enough and there was something wrong in the script.

I'll be there for SIG Instrumentation

This is intended to avoid having a dependency on node-exporter. The basic configuration provided by this repository should be installable on any Kubernetes cluster with a Prometheus server running. For...

Great work, thanks @JoaoBraveCoding! /lgtm /approve

I don't think a unit test would be meaningful here since it would essentially just test the go http library. /lgtm /assign @serathius

Hey @zroubalik, thank you for coming up with this proposal, I think this would be an amazing addition to this project. I would personally lean towards the CRD approach, as...

Thank you for the contribution @srinidhis94 :) /lgtm /approve /ok-to-test