Damien Grisonnet

icon indicating an email [email protected]

icon company Red Hat icon location Paris, France icon location Senior Software Engineer at Red Hat

Results 522 comments of Damien Grisonnet

Ability to include `process_start_time_seconds` in metrics

Yeah, you are correct, that is definitely the pod spec, not sure why I thought it was the configuration of prometheus-to-sd. Looking at the project a bit more, it seems...

Ability to include `process_start_time_seconds` in metrics

The telemetry endpoint should produce way fewer metrics than the other endpoint and ultimately you most likely also want to gather these metrics otherwise you'll be blind if anything goes...

Ability to include `process_start_time_seconds` in metrics

Theoretically, that would be a potential solution but in practice, it is more complex to do that with telemetry metrics as we don't control all the collectors that we have....

Ability to include `process_start_time_seconds` in metrics

That sounds reasonable to me considering that there are only a few metrics families on the telemetry endpoint so the performance impact shouldn't be significant.

Ability to include `process_start_time_seconds` in metrics

/remove-lifecycle stale

kube_endpoint_address_available and kube_endpoint_address_not_ready get computed by kube-state-metrics

@bavarianbidi in the FamilyGenerator struct there is a DeprecatedVersion field that you can fill: https://github.com/kubernetes/kube-state-metrics/blob/master/pkg/metric_generator/generator.go#L35 It will add the version at which the metric was deprecated to the HELP text...

Ability to configure --metric-allowlist and --metric-denylist after startup

I don't think this would add any complexity since users would still be able to reconfigure ksm by reloading it. To me this effort would be a great step forward...

Metrics kube_pod_container_status_last_terminated_reason can't distinguish if there is an exception happens

I don't think there is a well-defined list of reasons since it is just a string in the API. There is one reason that is called "Completed" for pods that...

test/extended: check apiserver request latency

Since the values that I observed in CI were varying a lot depending on the infrastructure and the kind of the job, I would take it slowly and first try...

test/extended: check apiserver request latency

I rebased the PR on top of https://github.com/openshift/origin/pull/26740, PTAL @deads2k