Damien Grisonnet comments

Results 522 comments of


                                            Damien Grisonnet

Streamline Metrics

We already have an e2e test verifying that metrics are conform with Prometheus standards: https://github.com/kubernetes/kube-state-metrics/blob/master/tests/e2e/main_test.go#L78-L95

Improve --metric-labels-allowlist handling of non-plural resource names

I would still treat resources in the singular form as invalid, it will just complexify the codebase to have to support both and we would have to propagate that change...

WIP: Add Support for Evented PLEG

/remove-sig instrumentation

add metrics for health checks (for later use in apiserver)

/triage accepted /assign @dashpole @dgrisonnet

add metrics for health checks (for later use in apiserver)

Setting release notes to none since this PR just adds a new metrics Interface that is not yet wired anywhere in the code. /release-note-none

add metrics for health checks (for later use in apiserver)

/lgtm

[WIP][DONT MERGE] New histogram: Pod start SLO duration

/triage accepted /assign @logicalhan @dashpole /cc

RUNTIME ERROR: couldn't open import "kube-prometheus/main.libsonnet": no match locally or in the Jsonnet library path

It might be because you haven't downloaded the jsonnet dependencies. Could you try running `make vendor` before building the manifests? Following the installation documentation should also help you: https://github.com/prometheus-operator/kube-prometheus#installing. Note...

RUNTIME ERROR: couldn't open import "kube-prometheus/main.libsonnet": no match locally or in the Jsonnet library path

Since your bug seems different than the original one reported in this issue, would you mind opening another bug?