Damien Grisonnet

Results 522 comments of Damien Grisonnet

@whitebear009 my previous comments are still unresolved, could you have a look at them?

Putting a hold for the API team to take some time to consider how to handle this new configuration parameter going forward. We are currently working on rewriting the existing...

Unholding since the initial concerns were cleared in this thread: https://github.com/openshift/microshift/pull/1030#discussion_r1006118685 /unhold

Yes, there should already be quite a huge amount of users since the whole ecosystem that imports https://github.com/kubernetes-monitoring/kubernetes-mixin is already using this metric. My main reason for changing the name...

@logicalhan makes sense, I addressed your comment. @wojtek-t can you please also take a look? My main concern now that we have added a deprecation period is that we will...

Yes this is just a renaming