Damien Grisonnet

Results 522 comments of Damien Grisonnet

Closing in favor of opening a dedicated issue in k/k to graduate the API to stable. /close

I can look into that. This would also align with the issue I opened in k/k kubernetes/kubernetes#102051. /assign

Agreed, having this flag would be a great addition to ksm. In v3, we can definitely improve the existing flags to make it easier since the current list kind of...

I am fine with these new metrics. To address some initial concerns that were raised in https://github.com/kubernetes/kube-state-metrics/issues/1465#issuecomment-855922085, it is very unlikely that these metrics will surface in kubelet today due...

I agree but I would still prefer to have the efforts split into different PRs since it will be easier to review. 1. Update CLI toolkit 2. Add config-file option...

Since this is a step of e2e testing and we want to get rid of shell scripts as much as possible in kube-state-metrics, I would be in favor of doing...

Then I guess it was already done and we somehow forgot :sweat_smile:, sorry about that @rexagod.

The unit tests are failing, you need to the update the test metadata to include the deprecation notice: https://github.com/kubernetes/kube-state-metrics/blob/master/internal/store/verticalpodautoscaler_test.go#L33-L40