Damien Grisonnet

Results 522 comments of Damien Grisonnet

These permissions are not needed by metrics-server. They were present a while back to make the e2e tests pass but in #799 it was proven that they are not necessary...

The `extension-apiserver-authentication` configmap is not created by default when you create a Kubernetes cluster with the default kube-apiserver options. It is only created if you setup apiserver client authentication as...

I also very much agree with these ideas :+1:

Sure, so the goal of this issue is to update the deployment manifests and instructions that we have in this repository under the [deploy](https://github.com/kubernetes-sigs/prometheus-adapter/tree/master/deploy) directory based on the more up-to-date...

@championshuttler are you still looking into this? /remove-lifecycle stale

Hello @JoaoBraveCoding my original idea was to first update the yaml manifest to match the changes made in kube-prometheus and then migrate to jsonnet: https://github.com/kubernetes-sigs/prometheus-adapter/issues/427. That said, if you prefer...

/remove-lifecycle stale /unassign championshuttler