metrics-server icon indicating copy to clipboard operation
metrics-server copied to clipboard

Prepared for Release v0.6.2

Open yangjunmyfm192085 opened this issue 3 years ago • 12 comments
trafficstars

/cc @serathius @dgrisonnet

Installation

kubectl apply -f https://github.com/kubernetes-sigs/metrics-server/releases/download/v0.6.2/components.yaml

Changes since v0.6.1

Fixes

  • Fix deadline exceeded errors caused by failure during metric parsing (https://github.com/kubernetes-sigs/metrics-server/issues/983, @yangjunmyfm192085)

yangjunmyfm192085 avatar Jun 06 '22 12:06 yangjunmyfm192085

/cc @serathius @dgrisonnet

yangjunmyfm192085 avatar Jun 06 '22 12:06 yangjunmyfm192085

Fixed the description by editing the top comment. LGTM.

serathius avatar Jun 06 '22 12:06 serathius

When will the helm chart be updated?

jsalatiel avatar Jun 24 '22 19:06 jsalatiel

LGTM

dgrisonnet avatar Jun 29 '22 10:06 dgrisonnet

Hi, @serathius Should we release v0.6.2?

yangjunmyfm192085 avatar Jul 04 '22 01:07 yangjunmyfm192085

Do we have any timeframe on when the 0.6.2 will be released? New chart will follow?

junior avatar Jul 19 '22 02:07 junior

Yes, this commit is pretty much needed to be able to use the chart in my case. It would be great to have a new release

tom-masson avatar Aug 26 '22 13:08 tom-masson

Hi, Any ETA on when we can get this released? We are blocked due to this issue, please do let us know if there is a workaround. We tried increasing metrics-resolution time but it didn't helped.

abhiTamrakar avatar Sep 16 '22 08:09 abhiTamrakar

Any else we need? /ping @serathius

liangyuanpeng avatar Sep 27 '22 14:09 liangyuanpeng

I too would love to see a new release....

jcpunk avatar Oct 17 '22 16:10 jcpunk

Yeah, I have submitted to the sig-instrumentation meeting for discussion, waiting for the discussion result

yangjunmyfm192085 avatar Oct 18 '22 03:10 yangjunmyfm192085

I'm also looking forward to release. Hopefully 0.6.2 will support Kubernetes >= 1.25. #1104

Edit: I was installing metrics-server incorrectly. 0.6.2 works fine with 1.25.

jameshearttech avatar Oct 20 '22 00:10 jameshearttech

/assign

dgrisonnet avatar Nov 21 '22 15:11 dgrisonnet

It seems that we would most likely want to fix https://github.com/kubernetes-sigs/metrics-server/issues/1096 in v0.6.2.

@yangjunmyfm192085 is there anything else that you have in mind for this release?

dgrisonnet avatar Nov 21 '22 15:11 dgrisonnet

let me take a look

yangjunmyfm192085 avatar Nov 21 '22 15:11 yangjunmyfm192085

It seems that we would most likely want to fix #1096 in v0.6.2.

@yangjunmyfm192085 is there anything else that you have in mind for this release?

Yeah, I checked again, everything is ok except #1096 needs to be fixed

yangjunmyfm192085 avatar Nov 21 '22 15:11 yangjunmyfm192085

@yangjunmyfm192085 I updated the changelog to include the latest version bumps, could you take a look?

dgrisonnet avatar Nov 25 '22 14:11 dgrisonnet

he changelog

ok, let me take a look

yangjunmyfm192085 avatar Nov 25 '22 14:11 yangjunmyfm192085

/lgtm

yangjunmyfm192085 avatar Nov 25 '22 14:11 yangjunmyfm192085

@dgrisonnet Do we need a note about the support of metrics-server 0.6.2 for kubernetes v1.25?

yangjunmyfm192085 avatar Nov 25 '22 14:11 yangjunmyfm192085

If we need to support kubernetes v1.25, the policy/v1beta1 of pdb needs to be changed to policy/v1

yangjunmyfm192085 avatar Nov 25 '22 14:11 yangjunmyfm192085

That's a good point, I would say let's stick to what was supported by v0.6.1 so v1.19 onward and not support v1.25 since policy/v1 was only introduced in v1.21. I'll create a PR to update the compat matrix.

dgrisonnet avatar Nov 25 '22 15:11 dgrisonnet

@yangjunmyfm192085 should this issue be closed?

stevehipwell avatar Dec 08 '22 14:12 stevehipwell

yeah. I think it should be closed.

yangjunmyfm192085 avatar Dec 09 '22 00:12 yangjunmyfm192085