Damien Grisonnet
Damien Grisonnet
> This should be a part of prometheus-adapter.libsonnet and be conditionally enabled. I don't see any reason for this to be an addon. That's a fair point, having it conditionally...
You can take the thanos sidecar setup of Prometheus as an example: https://github.com/prometheus-operator/kube-prometheus/blob/main/jsonnet/kube-prometheus/components/prometheus.libsonnet#L330-L344
Looks like https://github.com/prometheus-operator/kube-prometheus/blob/main/examples/minikube.jsonnet#L21-L23 also need to be updated.
Also: - https://github.com/prometheus-operator/kube-prometheus/blame/main/docs/migration-example/readme.md#L65-L67 - https://github.com/prometheus-operator/kube-prometheus/blob/main/docs/migration-example/my.release-0.8.jsonnet#L46-L48
My concerns from https://github.com/kubernetes/kube-state-metrics/issues/1758#issuecomment-1192710597 still applies. You could today remove labels via the otel-collector relabeling config but more complex aggregation similar to what Prometheus has with recording rules is not...
@mrueg wrote this doc https://github.com/kubernetes/kube-state-metrics/blob/main/docs/customresourcestate-metrics.md#verticalpodautoscaler to migrate VPA to CustomResourceState. It might be worth extending it to include all the VPA metrics that are going to be removed.
/kind support /triage accepted /assign
/kind support /triage accepted /assign @yangjunmyfm192085
/kind support /triage accepted /assign
From what I've seen in general, upstream is not very interested in FIPS compliance and it is usually expected to be the responsibility of vendors who want to obtain FEDRAMP....