metrics-server icon indicating copy to clipboard operation
metrics-server copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Set customed Host to request for node metrics

Open sdghchj opened this issue 3 years ago • 5 comments

What this PR does / why we need it:

Fixes #1067

sdghchj avatar Aug 15 '22 10:08 sdghchj

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: sdghchj (e3aff1ed86e46da204061b52aef40c71da9631ee)

linux-foundation-easycla[bot] avatar Aug 15 '22 10:08 linux-foundation-easycla[bot]

Hi @sdghchj. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 15 '22 10:08 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sdghchj Once this PR has been reviewed and has the lgtm label, please assign serathius for approval by writing /assign @serathius in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 15 '22 10:08 k8s-ci-robot

/easycla

sdghchj avatar Aug 16 '22 06:08 sdghchj

/check-cla

sdghchj avatar Aug 16 '22 06:08 sdghchj

/assign

logicalhan avatar Nov 03 '22 16:11 logicalhan

/assign @dgrisonnet

logicalhan avatar Nov 03 '22 16:11 logicalhan

Sorry, I don't know how to fix the tests. Can anyone give me a hand, what should I do next?

sdghchj avatar Nov 06 '22 03:11 sdghchj

I don't think a unit test would be meaningful here since it would essentially just test the go http library.

/lgtm

/assign @serathius

dgrisonnet avatar Nov 07 '22 11:11 dgrisonnet

Depending on Kubelet advertised address type this can be an incorrect behavior. Kubelet advertised it's address in Node status object. Available types are: NodeHostName, NodeInternalDNS, NodeInternalIP, NodeExternalDNS, NodeExternalIP.

Configuration you are setting doesn't make sense and might break in NodeHostName, NodeInternalDNS, NodeExternalDNS. We cannot merge it as it is.

serathius avatar Nov 07 '22 12:11 serathius

/hold

serathius avatar Nov 07 '22 12:11 serathius

Depending on Kubelet advertised address type this can be an incorrect behavior. Kubelet advertised it's address in Node status object. Available types are: NodeHostName, NodeInternalDNS, NodeInternalIP, NodeExternalDNS, NodeExternalIP.

Configuration you are setting doesn't make sense and might break in NodeHostName, NodeInternalDNS, NodeExternalDNS. We cannot merge it as it is.

I wonder whether a host name is required for a node ? So what about adding another custom header such as NodeHostName ? Or is there a better way to fix my issue?

sdghchj avatar Nov 15 '22 08:11 sdghchj

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Feb 13 '23 08:02 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Mar 15 '23 09:03 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Apr 14 '23 09:04 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 14 '23 09:04 k8s-ci-robot