David Eads
David Eads
The detail here is very good, thank you. Approve the PRR, the sig owns /lgtm for the move to beta in this release. /approve
The references for PRR look ok to me /approve
/milestone v1.26 /label lead-opted-in /label tracked/yes
> The release-note approach relies on the author and the reviewer to identify the breaking changes. I'd rather relying on the tool to force the author to add release-note. I...
Take a look at how I wired together the integration tests for the CRD server here: https://github.com/kubernetes/apiextensions-apiserver/blob/master/test/integration/basic_test.go#L45 . Basically it stands up an insecure server for a local integration test...
nesting is ugly, but I'll take it /lgtm
/override ci/prow/e2e-aws-ovn-serial
> I'm not sure whether this is the behavior we want or not, but it was a little unexpected. We should decide whether we want to issue tokens that cannot...
Currently this PR 1. still relies on openshift APIs not present in microshift 2. does not provide a mechanism to set the user as expected by the test being run...
/lgtm /hold cancel