David Eads
David Eads
/override ci/prow/e2e-aws-ovn-serial
no conflict with the PR that merged 12h ago.
/approve
origin is nothing but tests now, may as well simply use the top level /lgtm
@rtheis Based on the slack thread, this was an issue in the test scenario, not the kube project, correct?
> @fedebongio, we will be adding a `NodeLogOptions` counterpart to [PodLogOptions](https://github.com/kubernetes/kubernetes/blob/548ad1b8d35d51e6d33ea21dcc75d60a789b00e6/pkg/apis/core/types.go#L4409). Will that require a review from `sig/api-machinery`? The `NodeLogOptions` struct can be handled by sig-node. If you need help...
This seems unlikely to flake, but also unlikely to actually test the functionality works. I'm ok with if you really want it. /approve /hold hold in case you want to...
Significant improvement, thanks for taking the effort to do this. There may still be some possible improvements if you wanted to handle all endpoints like this, but this looks a...
I think it's important to work out what kind of permissions should be required in order to add lien. The KEP as currently written allows a namespace admin or editor...