enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Aggregated Discovery

Open Jefftree opened this issue 2 years ago • 46 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Aggregated Discovery

  • Kubernetes Enhancement Proposal: KEP

  • Discussion Link:

  • Primary contact (assignee): @Jefftree

  • Responsible SIGs: SIG API Machinery, SIG CLI

  • Enhancement target (which target equals to which milestone):

    • Alpha release target (x.y): 1.26
    • Beta release target (x.y): 1.27
    • Stable release target (x.y): 1.30
  • [x] Alpha

  • [x] Beta

    • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/3722
    • [x] Code (k/k) update PR(s):
      • https://github.com/kubernetes/kubernetes/pull/116145
      • https://github.com/kubernetes/kubernetes/pull/116108
      • https://github.com/kubernetes/kubernetes/pull/115770
      • https://github.com/kubernetes/kubernetes/pull/115630
    • [x] Docs (k/website) update(s): https://github.com/kubernetes/website/pull/40024
  • [ ] Stable

    • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4472
    • [x] Code (k/k) update PR(s):
      • https://github.com/kubernetes/kubernetes/pull/122880
      • https://github.com/kubernetes/kubernetes/pull/122882
      • https://github.com/kubernetes/kubernetes/pull/122883
      • https://github.com/kubernetes/kubernetes/pull/122977
      • https://github.com/kubernetes/kubernetes/pull/123517
    • [x] Docs (k/website) update(s):
      • https://github.com/kubernetes/website/pull/45267

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

Jefftree avatar Jun 07 '22 18:06 Jefftree

/sig api-machinery /sig cli

Jefftree avatar Jun 07 '22 18:06 Jefftree

/milestone v1.25

Priyankasaggu11929 avatar Jun 10 '22 17:06 Priyankasaggu11929

Hello @Jefftree 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [ ] KEP file using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable
  • [ ] KEP has a updated detailed test plan section filled out
  • [ ] KEP has up to date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would just need to get the open KEP PR https://github.com/kubernetes/enhancements/pull/3364 merged by the Enhancements Freeze.

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

Priyankasaggu11929 avatar Jun 11 '22 04:06 Priyankasaggu11929

Hello @Jefftree 👋, just a quick check-in again, as we approach the 1.25 enhancements freeze.

Please plan to get the open KEP PR merged before enhancements freeze on Thursday, June 23, 2022 at 18:00 PM PT.

For note, the current status of the enhancement is atat-risk. Thank you!

Priyankasaggu11929 avatar Jun 17 '22 17:06 Priyankasaggu11929

With KEP PR #3364 merged now, the enhancement is ready for the upcoming Enhancements Freeze.

For note, the status is now marked as tracked. Thank you so much!

Priyankasaggu11929 avatar Jun 24 '22 00:06 Priyankasaggu11929

Hello @Jefftree 👋, 1.25 Release Docs Shadow here.

This enhancement is marked as ‘Needs Docs’ for the 1.25 release. Please follow the steps detailed in the documentation to open a PR against the dev-1.25 branch in the k/website repo. This PR can be just a placeholder at this time and must be created by August 4.


Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. Thank you!

didicodes avatar Jul 13 '22 13:07 didicodes

Hi @Jefftree, Enhancements team here again 👋

Checking in as we approach Code Freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure that the following items are completed before the code-freeze:

  • [ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [ ] All PRs are fully merged by the code freeze deadline.

Currently, the status of the enhancement is marked as at-risk

Thanks :)

Atharva-Shinde avatar Jul 25 '22 16:07 Atharva-Shinde

Hey @Jefftree , reaching out again as we approach Code Freeze at 01:00 UTC on this Wednesday i.e 3rd August 2022. Try to get this PR https://github.com/kubernetes/kubernetes/pull/111409 merged and update the Issue Description by adding the PR linked, before the code-freeze :)

The status of the enhancement is still marked as at-risk

Atharva-Shinde avatar Aug 01 '22 16:08 Atharva-Shinde

Hello, we will be dropping this enhancement for 1.25. Thanks!

Jefftree avatar Aug 01 '22 18:08 Jefftree

Thanks for the update @Jefftree ! I have marked this enhancement as Removed from milestone in the tracking sheet. Clearing the milestone /milestone clear

Atharva-Shinde avatar Aug 01 '22 18:08 Atharva-Shinde

If you're moving forward with this, please update the kep.yaml that just merged as it has milestone 1.25 still :)

kikisdeliveryservice avatar Sep 16 '22 17:09 kikisdeliveryservice

/milestone v1.26 /label lead-opted-in /label tracked/yes

deads2k avatar Oct 03 '22 19:10 deads2k

@deads2k: Can not set label tracked/yes: Must be member in one of these teams: [release-team-enhancements release-team-leads]

In response to this:

/milestone v1.26 /label lead-opted-in /label tracked/yes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 03 '22 19:10 k8s-ci-robot

/label tracked/yes /remove-label tracked/no

rhockenbury avatar Oct 03 '22 21:10 rhockenbury

Hello @Jefftree 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage alpha for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [x] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: 1.26
  • [x] KEP readme has a updated detailed test plan section filled out
  • [x] KEP readme has up-to-date graduation criteria
  • [x] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the latest milestone to 1.26 and the milestone at which this feature was, or is targeted to be, at each stage, here

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

ruheenaansari34 avatar Oct 04 '22 03:10 ruheenaansari34

Quick reminder - Enhancement freeze is 2 days away. If you are still looking to get this enhancement into v1.26, please plan to make the updates to the KEP yaml and get the PR merged.

ruheenaansari34 avatar Oct 04 '22 15:10 ruheenaansari34

With #3534 merged, this is tracked for v1.26.

rhockenbury avatar Oct 07 '22 01:10 rhockenbury

@Jefftree Are docs required for this KEP? If so, who will be opening the docs PR for k/website?

mickeyboxell avatar Oct 20 '22 23:10 mickeyboxell

Hi @Jefftree 👋,

Checking in once more as we approach the 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • [ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [ ] All PRs are fully merged by the code freeze deadline.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze. If you do have any other k/k PRs open, please link them to this issue.:

  • https://github.com/kubernetes/kubernetes/pull/112214
  • https://github.com/kubernetes/kubernetes/pull/112113
  • https://github.com/kubernetes/kubernetes/pull/112130

As always, we are here to help should questions come up. Thanks!

ruheenaansari34 avatar Nov 02 '22 13:11 ruheenaansari34

Hi @Jefftree 👋 This enhancement is marked as Needs Docs for 1.26 release. Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time. It must be created by November 9. For more information, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

mickeyboxell avatar Nov 02 '22 14:11 mickeyboxell

@ruheenaansari34 the three PRs you linked were rolled into a single one "Aggregated discovery server changes" linked below:

This KEP has two outstanding PRs needing to be merged by code freeze:

  • https://github.com/kubernetes/kubernetes/pull/113171
  • https://github.com/kubernetes/kubernetes/pull/113599

alexzielenski avatar Nov 06 '22 14:11 alexzielenski

Thanks for the information. Please ensure to link them in the issue description as well.

ruheenaansari34 avatar Nov 07 '22 21:11 ruheenaansari34

Hey @Jefftree, please remember to open a PR against dev-1.26 branch in the k/website repo. This PR is needed by November 9 and can be just a placeholder at this time.

mickeyboxell avatar Nov 08 '22 16:11 mickeyboxell

Hello 👋, 1.26 Enhancements Lead here.

Unfortunately, this enhancement did not meet requirements for code freeze.

If you still wish to progress this enhancement in v1.26, please file an exception request. Thanks!

NOTE: PRs are only waiting on queue, and have lgtm and approve.

/milestone clear /label tracked/no /remove-label tracked/yes /remove-label lead-opted-in

rhockenbury avatar Nov 09 '22 01:11 rhockenbury

Just seeing that now unfortunately. How come this "does not meet the requirements"? The code was merged by code-freeze date.

apelisse avatar Nov 14 '22 16:11 apelisse

@rhockenbury was this removed in error? Which requirement was missing?

lavalamp avatar Nov 14 '22 17:11 lavalamp

Yes, I meant to add this one back. The PRs were approved before the code freeze deadline.

/milestone v1.26 /label tracked/yes /remove-label tracked/no /label lead-opted-in

rhockenbury avatar Nov 14 '22 23:11 rhockenbury

Please link the final KEP from the main text of this Enhancement, thanks!

jberkus avatar Nov 15 '22 01:11 jberkus

/remove-label lead-opted-in /remove-label tracked/yes /label tracked/no /milestone clear

marosset avatar Dec 14 '22 19:12 marosset

/milestone v1.27 /label lead-opted-in /stage beta

deads2k avatar Jan 23 '23 22:01 deads2k