David Eads

Results 240 comments of David Eads

/milestone v1.27 /label lead-opted-in /stage stable

PRR is complete enough for alpha. Please consider what metrics you'll add for beta when this gets enabled by default. /approve

> @deads2k I have addressed the final comment . Can you please review/approve this ? Thanks ! Thanks. The answer looks good. I'm not sure if a bot will require...

The API described here makes sense to me. I'm not entirely clear on how the synthetic is identifiable as "initial events have been sent" versus other normal bookmarks.

> My initial idea was that it's simply "the first bookmark within a given watch request". > I decided not to put it as I didn't feel the strong need...

This lgtm for apimachinery and PRR /lgtm /approve /hold I'm holding so that @lavalamp gets a chance to comment on the statement of future intent: https://github.com/kubernetes/enhancements/pull/3725#discussion_r1084501801 Feel free to release...