origin icon indicating copy to clipboard operation
origin copied to clipboard

Check version when discovery client

Open ingvagabund opened this issue 2 years ago • 2 comments

getDiscoveryClient() does not checks whether a cluster is reachable. One needs to e.g. check cluster version to verify the connection with the cluster. A.k.a allow dry-run to skip api group filter builder when a cluster is not reachable.

ingvagabund avatar Sep 21 '22 12:09 ingvagabund

nesting is ugly, but I'll take it

/lgtm

deads2k avatar Sep 22 '22 15:09 deads2k

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Sep 22 '22 15:09 openshift-ci[bot]

/override ci/prow/e2e-aws-ovn-serial

deads2k avatar Sep 22 '22 15:09 deads2k

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/e2e-aws-ovn-serial

In response to this:

/override ci/prow/e2e-aws-ovn-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Sep 22 '22 15:09 openshift-ci[bot]

@ingvagabund: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade c275cc02ff9c3a17a93ac2b60b6b6eda339a66a0 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-cgroupsv2 c275cc02ff9c3a17a93ac2b60b6b6eda339a66a0 link false /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-aws-ovn-single-node-serial c275cc02ff9c3a17a93ac2b60b6b6eda339a66a0 link false /test e2e-aws-ovn-single-node-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Sep 23 '22 04:09 openshift-ci[bot]

/retest-required

Remaining retests: 0 against base HEAD 53173121bd86b940c4a70e2105ea4ebcbddec2bd and 2 for PR HEAD c275cc02ff9c3a17a93ac2b60b6b6eda339a66a0 in total

openshift-ci-robot avatar Sep 23 '22 05:09 openshift-ci-robot