origin icon indicating copy to clipboard operation
origin copied to clipboard

USHIFT-285: MicroShift: allow CLI creation without OpenShift APIs

Open pacevedom opened this issue 3 years ago • 16 comments

Swaps project API with k8s namespaces in test/extended/util package. Automatic detection of project API to create a CLI object according to whats available in the cluster.

pacevedom avatar Aug 17 '22 11:08 pacevedom

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar Aug 17 '22 11:08 openshift-ci[bot]

/retest-required

pacevedom avatar Aug 18 '22 21:08 pacevedom

/retest-required

pacevedom avatar Aug 19 '22 14:08 pacevedom

/approve

dhellmann avatar Aug 29 '22 19:08 dhellmann

/retitle USHIFT-285: MicroShift: allow CLI creation without OpenShift APIs

ggiguash avatar Aug 31 '22 09:08 ggiguash

/lgtm

dhellmann avatar Aug 31 '22 12:08 dhellmann

/assign @knobunc

pacevedom avatar Aug 31 '22 15:08 pacevedom

/retest-required

pacevedom avatar Sep 01 '22 08:09 pacevedom

/retest

dhellmann avatar Sep 06 '22 20:09 dhellmann

/cc @ingvagabund

pacevedom avatar Sep 08 '22 15:09 pacevedom

Currently this PR

  1. still relies on openshift APIs not present in microshift
  2. does not provide a mechanism to set the user as expected by the test being run
  3. does not provide the user with permissions to work in the namespace
  4. does not provide interoperability with the functionality it replaces
  5. does not provide congruent gating guarantees for all downstream consumers

/hold until the functionality is a drop-in replacement /assign @ingvagabund

deads2k avatar Sep 08 '22 18:09 deads2k

Added user certificate handling for authentication.

pacevedom avatar Sep 15 '22 08:09 pacevedom

/lgtm /hold cancel

deads2k avatar Sep 21 '22 20:09 deads2k

/retest-required

pacevedom avatar Sep 22 '22 06:09 pacevedom

/retest-required

pacevedom avatar Sep 22 '22 10:09 pacevedom

/lgtm

deads2k avatar Sep 22 '22 12:09 deads2k

/override ci/prow/e2e-aws-ovn-serial

deads2k avatar Sep 22 '22 12:09 deads2k

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/e2e-aws-ovn-serial

In response to this:

/override ci/prow/e2e-aws-ovn-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Sep 22 '22 13:09 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, dhellmann, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Sep 22 '22 13:09 openshift-ci[bot]

no conflict with the PR that merged 12h ago.

deads2k avatar Sep 22 '22 13:09 deads2k

@pacevedom: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node 83972e3e3ef96d763007810ab907c06c0e4e42c4 link false /test e2e-aws-single-node
ci/prow/e2e-aws-single-node-upgrade 83972e3e3ef96d763007810ab907c06c0e4e42c4 link false /test e2e-aws-single-node-upgrade
ci/prow/e2e-agnostic-cmd 83972e3e3ef96d763007810ab907c06c0e4e42c4 link false /test e2e-agnostic-cmd
ci/prow/e2e-gcp-upgrade 83972e3e3ef96d763007810ab907c06c0e4e42c4 link true /test e2e-gcp-upgrade
ci/prow/e2e-aws-ovn-single-node-serial f5cc41246254c1cf0e5826cfa4b8416c3cec1b80 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node-upgrade f5cc41246254c1cf0e5826cfa4b8416c3cec1b80 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Sep 22 '22 13:09 openshift-ci[bot]