David Eads

Results 240 comments of David Eads

heh, caught one: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/29100/pull-ci-openshift-origin-master-e2e-gcp-ovn-upgrade/1835737214349217792 package server going offline during upgrade of package server. Better check to be sure it's a graceful termination.

PRR looks good and the scalability section is valuable. We'll have to build it out a little more as we gain experience in alpha. /approve

/test verify now that https://github.com/openshift/api/pull/1909 merged. It might be ready. if not, try again in an hour.

minor comments, lgtm otherwise.

/override ci/prow/e2e-aws-ovn-ipsec-serial

Some high level thoughts. If the goal "there a spoke cluster credentials, divided into per-component namespaces, retrievable via ClusterProfile.name and component.name", then a ClusterProfile API field isn't necessary. 1. make...

lgtm please squash in the fixups and we can merge.