David Eads

Results 240 comments of David Eads

/hold cancel /override ci/prow/e2e-aws-serial

> We need to figure out how to allow label and annotation update on projects for project admins that is "safe". May be whitelist of allowed things to change. Do...

> At a minimum description and display, and _maybe_ labels, that's all. Display and description are already allowed: https://github.com/openshift/origin/blob/master/pkg/project/api/v1/types.go#L45-L46, I don't think I'd want to open up arbitrary labels for...

> It's probably going to be an admin decision. We will have to enable labels > for end users as soon as they have more than a few projects. I...

@mfojtik make sure that someone doing this considers the repercussions of user-settable labels and annotations on a namespace. Perhaps requiring a known prefix would work.

is this blocked on https://github.com/openshift/cluster-authentication-operator/pull/576?

I'm not sure if this is a bug. How does a user know this feature isn't working in their cluster? /assign @danwinship

related enhancement https://github.com/kubernetes/enhancements/pull/3160

The detail here is very good, thank you. Approve the PRR, the sig owns /lgtm for the move to beta in this release. /approve