David Eads
David Eads
/lgtm /approve
> I'm supportive. > > @deads2k @johnbelamaric - we probably need one more vote from one of you :) me too. /lgtm /hold holding for @johnbelamaric
It would be nice to have a partial struct and some godoc to inspect the API change. On first blush I'm expecting something like ```go type PodFailurePolicyRule struct { Action...
/milestone v1.28 /label lead-opted-in
Thanks, lgtm for both sig and PRR /lgtm /approve /hold cancel
I'm in favor of this proposal. I like the consistency with validation policy CEL expression. I think that would make the support for secondary ACL checks "just work", but I'd...
minor updates requested, but I don't think they're contentious. lgtm otherwise. PRR also looks good and the advice from Han about metrics looks good as well. /approve /assign @jpbetz @lavalamp...
/approve /hold holding for and answer to @bobbypage's question. I don't think an already fixed performance degradation changes the PRR answers, but it's worth addressing.
> @deads2k Are you okay removing the hold? Yes, thank you for the updates. /hold cancel
As long as this approach follows the equivalent webhook feature in terms of supported functions and the like, this looks ok to me. I see why parameters were included in...