Chenna Keshava B S

Hello, Thank you for this change. 1. This change needs to be placed under the "Unreleased Version" at the top of the CHANGELOG file. At the moment, v3.0.0 has already...

I will go through the rest of the files/comments once the cpp code is finalized and this PR is ready for review.

> > Thanks for the PR. For the sake of completeness, I'd like to mention two other packages, which have been maintained frequently: > > > > * https://github.com/pylint-dev/pylint >...

Furthermore, I'm getting many `DAR...` errors from the linter on my local computer (I'm using Python 3.11). ``` xrpl-py-py3.11➜ xrpl-py git:(pydoclint) poetry run poe lint Poe => poetry run flake8...

> > Furthermore, I'm getting many `DAR...` errors from the linter on my local computer (I'm using Python 3.11). > > Did you run `poetry install` first to get the...

I didn't see a mention of batchnet in this PR. Did you intend to add that faucet-host in this python library? Here's the [relevant file](https://github.com/XRPLF/xrpl.js/pull/2801/files#diff-06e6fcfbef84f4790b1e91e8790acd725ebe144d33bf3c10c233540cbaae48c0) from JS library PR: [This](https://github.com/XRPLF/xrpl-py/blob/f1488c175c368584636ad217479bf96739623142/xrpl/asyncio/wallet/wallet_generation.py#L17)...

@mvadari I only have [one concern left](https://github.com/XRPLF/xrpl-py/pull/757#discussion_r2132608674) that needs to be addressed. Apart from that, this PR looks good.

The CodeRabbit AI does not make a mention of the changes pertaining to `tx_json` and `transaction` fields. I also don't understand the diagram because `TransactionStream` and `API` do not refer...

If a transaction includes the `NetworkID` field, then it fails on `mainnet, testnet, devnet` (any network whose network_id < 1025). Docs: https://xrpl.org/docs/references/protocol/transactions/common-fields/#networkid-field How can we disambiguate between these networks with...

What is the expected notice period before a deprecated method can be removed from the codebase? Is it one major-version release cycle ?