Chenna Keshava B S

Results 79 comments of Chenna Keshava B S

In the file `data_utils.py` at line 14, shouldn't the length of the padding be equal to `(k - 1)`, where `k` is the size of the convolution filter?

Hello, Can you please further explain the first proposed solution? What do you mean by clients connecting to websockets -- Are you referring to the RPC calls that can executed...

I had to use `std::numeric_limits::max()` in a few places to return a default value (in case of an overflow). Do I need to store this value in a variable for...

@greg7mdp Sorry my bad. I forgot to remove it. Completed now 👍

> Almost there! Done :) I have also removed extra import statements and refactored one more if-else condition into a value_or statement. Do I need to clean up the commits?...

> I have executed the unit tests, I didn't observe any failures. 👍

> Okat, thanks for helping me out greg!

I have a question. This file `src/ripple/protocol/jss.h` has certain references to `AccountTxOld` and `offset` in its comments. Shall I remove them as well?

@scottschurr @nbougalis let me know if this looks okay.

> Okay, I have done the suggested changes 👍