Update CHANGELOG.md
High Level Overview of Change
Context of Change
Type of Change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Refactor (non-breaking change that only restructures code)
- [ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
- [ ] Documentation Updates
- [ ] Release
Did you update CHANGELOG.md?
- [ ] Yes
- [ ] No, this change does not impact library users
Test Plan
Hello, Thank you for this change.
- This change needs to be placed under the "Unreleased Version" at the top of the CHANGELOG file. At the moment, v3.0.0 has already been released.
- There is a mixture of SECP256K1 and ED25519 algorithms used as defaults in the codebase. This needs to be fixed for the sake of consistency. https://github.com/XRPLF/xrpl-py/blob/fd278e0a40de5d4f17da066cf14f4b66f4f9f9cc/xrpl/wallet/main.py#L122 https://github.com/XRPLF/xrpl-py/blob/fd278e0a40de5d4f17da066cf14f4b66f4f9f9cc/xrpl/wallet/main.py#L208
^^ Here are two different default-choices used in two different methods.
Walkthrough
The pull request updates the CHANGELOG.md file to document significant changes in the project. It adds an entry for the new include_deleted parameter in the ledger_entry request and notes a breaking change that removes support for Python 3.7, making Python 3.8 the new default. Additionally, it addresses a fix related to retrieving FeeSettings values and summarizes updates from previous versions regarding various enhancements and removals.
Changes
| File | Change Summary |
|---|---|
| CHANGELOG.md | Updated to include new include_deleted parameter in ledger_entry request and breaking change for Python version support. Added historical updates on various changes across releases. |
Possibly related PRs
- #721: The main PR and this retrieved PR both involve the addition of the
include_deletedparameter to theledger_entryrequest, indicating a direct code-level connection.
Suggested reviewers
- ckeshava
- shawnxie999
- pdp2121
🐇 In the changelog, we hop and play,
New features added, come what may!
Python 3.8, we now embrace,
Withinclude_deleted, we quicken the pace.
From drops to fees, all changes are clear,
A joyful update, let’s give a cheer! 🎉
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
-
I pushed a fix in commit <commit_id>, please review it. -
Generate unit testing code for this file. -
Open a follow-up GitHub issue for this discussion.
-
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:-
@coderabbitai generate unit testing code for this file. -
@coderabbitai modularize this function.
-
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:-
@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase. -
@coderabbitai read src/utils.ts and generate unit testing code. -
@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format. -
@coderabbitai help me debug CodeRabbit configuration file.
-
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
-
@coderabbitai pauseto pause the reviews on a PR. -
@coderabbitai resumeto resume the paused reviews. -
@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository. -
@coderabbitai full reviewto do a full review from scratch and review all the files again. -
@coderabbitai summaryto regenerate the summary of the PR. -
@coderabbitai resolveresolve all the CodeRabbit review comments. -
@coderabbitai configurationto show the current CodeRabbit configuration for the repository. -
@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.