Chenna Keshava B S
Chenna Keshava B S
Okay, I understand that. By that reasoning, `Transaction.from_xrpl` should not accept non-`CamelCase` encoding of JSON inputs. Am I right? I couldn't find equivalent functions in the Typescript (xrpl.js) codebase. Are...
ok thanks, that's helpful
@dependabot rebase
@mvadari `black` does not have a command line option titled `--fix`. As per their recent release notes, `black` does not support Python 3.8 anymore. In my local system, I don't...
@mvadari I'm unable to replicate the behavior of the CI/CD step. I don't get the `BLK100` error message, despite having identical environment installation. ``` ➜ xrpl-py git:(dependabot/pip/black-24.8.0) poetry run flake8...
I didn't find any usage of `@deprecated` decorator in the codebase. As indicated in this commit: [02fc14a](https://github.com/XRPLF/xrpl-py/pull/742/commits/02fc14a551ce6ede38316bf64c20b5912842e11c), we can remove these two dependencies. Older rippled API versions are indicated by...
> > I believe all the `@deprecated` functions were removed. IMO we shouldn't remove the dependencies, in case we want to deprecate functions in the future. Are there valid uses...
@khancode Please review this PR at your convinience
The integration and snippet tests are not reliable. I'm observing these errors: (Integration Test Python 3.8): `xrpl.asyncio.wallet.wallet_generation.XRPLFaucetException: Unable to fund address with faucet after waiting 40 seconds ` Snippet test...
@justinr1234 @khancode can you please review this at your convinience?