Chenna Keshava B S
Chenna Keshava B S
> > @khancode the said amendment is already present in the rippled.cfg file: https://github.com/ckeshava/xrpl-py/blob/cred/.ci-config/rippled.cfg#L186 > > In fact, it is present in the `main` branch of xprl-py repository. > >...
thank you all for reviewing this PR
https://github.com/coderabbitai full review
Hello @rippleitinnz , can you please address the comments on this PR ?
It's also difficult for me to understand projections for the fees and reserves. If we could explain the process of consensus in a more easier/visual manner, that would be helpful....
Hello, `DepositPreauth` transaction also deals with arrays of credentials. It is helpful to decode those hex-strings as well. Here's an exanple: https://github.com/XRPLF/XRPL-Standards/tree/master/XLS-0070d-credentials#124-depositpreauth
@JordiParraCrespo Here is my branch with the concerned test case: https://github.com/XRPLF/xrpl.js/compare/main...ckeshava:xrpl.js:IssuedAmountPaymentTest?expand=1 Let me know what I'm missing
@yannickrocks Is this still an issue? Are you auto-filling this transaction? Since the autofill method has changed over the past few months, it would be great if you can share...
okay. I'll close this issue. If you have any more questions, please re-open it.
Clarification: Why are we supporting `snake_case` in the `from_dict` function while proposing the opposite in the `from_xrpl` function? The two functions (`from_xrpl` and `from_dict`) appear to be doing similar things...