Chenna Keshava B S
Chenna Keshava B S
> Does this field also exist in `server_state` responses? I don't see this field in my empirical observations with the WebSocket tool (or) with my local rippled instance. In the...
@mvadari thanks for the early feedback
@mvadari thanks for the feedback. I believe I have addressed all your comments
Regarding the linter failures, I'd prefer to merge this PR first: https://github.com/XRPLF/xrpl-py/pull/742 That should bring around some clarity on the `black` linter expectations.
@mDuo13 thanks for pointing out the `LedgerEntry` RPC. I have included an implementation in this commit: [3814a94](https://github.com/XRPLF/xrpl-py/pull/759/commits/3814a948c65b8b81895354544fbc4bfdad67c641)
@mDuo13 thank you. By Credential faucet, are you referring to tutorials/example-snippets ? I discovered an unpleasant fact just now. The `ledger_entry` RPC accepts a `Credential` input and the `DepositPreauth` transaction...
> Doesn't matter too much, since there are other similar issues all over the codebase (e.g. the `DepositPreauth` transaction and the `DepositPreauth` ledger object). okay nice, that's a relief
@khancode I have addressed all pending comments
@khancode I have responded to/incorporated all your comments as of 387f72b5
@khancode the said amendment is already present in the rippled.cfg file: https://github.com/ckeshava/xrpl-py/blob/cred/.ci-config/rippled.cfg#L186 In fact, it is present in the `main` branch of xprl-py repository.