Chenna Keshava B S
Chenna Keshava B S
Working on these unit tests would be a great way to understand this codebase for new engineers
I see, okay, this makes sense.
Hello, I don't understand a few aspects of this issue. > The network would be more resilient if the VL were cached by public key instead of endpoint. The ValidatorList...
@mvadari I felt it is more appropriate to make the `deliver max` changes in the `from_dict` overload. The `autofill` and other utility functions work with a `Transaction` object. Since `DeliverMax`...
@mvadari I agree that there are limitations in my current design. If I were to make this change in `autofill` method, how can I go about it? `autofill` takes in...
I have moved the changes to `Transaction.from_dict` from the `Payment` class. `from_xrpl` invokes `from_dict` in the course of its actions. I felt the former is most appropriate to accomodate these...
I've addressed your comments @mvadari 👍
@mvadari does this design look okay? Can I do the same for JS too?
@khancode can you please take a look at this PR? does this design look alright? @justinr1234 I need some clarification on your prior comments. Let me know if I need...
the snippets tests are failing due to an unfunded account (We believe it lacks "USD" tokens). It will need to be addressed in a separate PR