Chenna Keshava B S
Chenna Keshava B S
If there are no objections, I'd like to merge this PR. Thank you all for your feedback
Yes, developers will get an error like: ``` ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/ckeshavabs/xrpl-py/tests/unit/models/requests/test_channel_authorize.py", line 13, in test_has_secret_only_is_valid request = ChannelAuthorize( File "/Users/ckeshavabs/xrpl-py/xrpl/models/utils.py", line 59, in new_init raise...
@mvadari 👍 I've added unit tests to `Sign` and `ChannelAuthorize` classes: `tests/unit/models/requests/test_channel_authorize.py` and `tests/unit/models/requests/test_sign.py` fixed in commit: b0d0ffaa6bab8b259c5bad8973661ef1bcfb52de
@mvadari I have added the unit tests, would you be able to check this PR again?
@mvadari could you take a look at this PR? do you suggest any other changes?
@khancode @justinr1234 could you guys take a look at this PR at your convinience?
Please let me know if there are any objections. I'd like to merge this PR
Where can I find information about the behavior of Batch transactions with respect to `ter` codes? If one of the inner transaction ends up with a `ter` result, will it...
@julian78780 ping: There is already a ticket for the issue that we recently discussed.
I am able to view this page on Chrome browser Has this issue been resolved?