Chenna Keshava B S

Results 241 comments of Chenna Keshava B S

@ubuddemeier You are correct, the fix is similar: https://github.com/XRPLF/xrpl-py/pull/713 Regarding the request-IDs, please refer to this discussion: https://github.com/XRPLF/xrpl-py/issues/718#issuecomment-2195457626 For a collision to occur, the `random` math library would need to...

> hey author here. i think you're probably right about collisions with request IDs. we should be using a dictionary to determine what IDs are already in use, although i'm...

This repository is organized into distinct Javascript packages (`xrpl`, `ripple-binary-codec` and so forth). Consequently, each of them have their own LICENSE files: https://github.com/XRPLF/xrpl.js/blob/main/packages/xrpl/LICENSE Is this required for any legal purposes?...

Hello! I'd like to add that both the [`book_changes` JSON-RPC method](https://xrpl.org/docs/references/http-websocket-apis/public-api-methods/path-and-order-book-methods/book_changes) and the [book_changes subscription stream](https://xrpl.org/docs/references/http-websocket-apis/public-api-methods/subscription-methods/subscribe#book-changes-stream) support is missing in the xrpl.js client library. For the sake of feature-parity with...

I'm working on fixing the integration and browser tests, however I'd love to get a round of code-reviews. I'm not entirely sure why the integ-tests are not connecting to the...

@Patel-Raj11 The relevant tests in Github CI have passed.

@pdp2121 Please let me know if you have any comments on this PR.

I was of the understanding that `server_definitions` portrays the peer-to-peer communication standard between any two nodes in the XRPL blockchain. That being the case, `DeliverMax` is not a recognized serialized-field...

Hello Dennis, could you elaborate on this issue? The inner batch transactions are similar to the XRPL transactions, except for the fields pertaining to the Fees and Sequence. Do you...

Note: You need to enable the PermDelegation amendment in the config file: https://github.com/XRPLF/xrpl.js/actions/runs/20116926294/job/57728468166#step:9:119