Chenna Keshava B S

Results 241 comments of Chenna Keshava B S

@khancode can you please review this PR?

Under the "Possible Errors" section, `"malformedDocumentID"` needs to be documented. This error is returned for incorrectly specified Oracle ledger objects. This is the [source code](https://github.com/XRPLF/rippled/blob/cc0177be8712ca367134aa6599b7328bbc5e6bc5/src/xrpld/rpc/handlers/LedgerEntry.cpp#L642C44-L642C65) responsible for that error.

I'm not able to find requests which increase the queue size ``` class TestWebSocketClient(TestCase): """Performace test of the async web_socket_client.""" def test_web_socket_client(self: TestWebSocketClient) -> None: URL = "wss://s.devnet.rippletest.net:51233" with WebsocketClient(URL)...

> _messages `client._messages` has a `qsize` of `0`

I don't have a good idea to test this change. But irrespective of the impact on this issue, I think this change is useful. I don't know which inputs would...

Thanks for the quick approval @pdp2121 The PriceOracle amendment hasn't been enabled on the mainnet yet, so I don't believe it needs a mention in the HISTORY file. If you...

> Why are there now keypairs changes in this PR? Sorry, my bad. I messed up the git history. I rectified it with the relevant cherry-picked commits.

@achowdhry-ripple can you please review this PR at your convenience?

This PR is not required. Check this comment thread for more details: https://github.com/XRPLF/xrpl.js/pull/2795#discussion_r1968316704

Thanks for the reply. I had made a mistake whilst specifying the `account` value. This RPC appears to be working fine, as far as `Verifiable Credentials` are concerned. The documentation...