Warner Losh
Warner Losh
not sure the state, but @concussious is a committer now and should land / close / etc
OK. At this point I think this is a good change. Not sure what was originally submitted, and there are style(9) issues with the patch... and with the whole rest...
> do we even have any existing tests? I don't think so. This looks safe-enough that testing the new functionality by hand suffices.
Thanks for the contribution. I'm seeing issues with running it: ``` /rescue/rescue --list rescue: --list not compiled in usage: rescue ..., where is one of: cat chflags chio chmod cp...
hmm, I had to build it twice, but it's happy now.
landed f122045e36dd
Looks like many of these have been pushed. Since the remainder do contain user-visible changes, I'm pushing them. However, there's many non-visble changes (eg just to comments) that I'm only...
The change itself looks good to me. It should be two commits: 1 for the slight optimization (which is borderline interesting, to be honest) 1 for the additional malloc check....
looking at this change against what's in main made me change my mind. This needs to be rebased and reworked. Tagging as such, since it's not ready.
Please attend to the style checker reported problems. the style checker found several, and can be run interactively as `tools/build/checkstyle9.pl main..` I'm working to get those reports more inline... But...