Warner Losh comments

Results 449 comments of


                                            Warner Losh

swab.c(libc): use a simplified version of byte swapping

Looking very close. A couple minor nits on the license. If you change, could you also fold these two commits together? Thanks!

swab.c(libc): use a simplified version of byte swapping

I think this is ready, but it may still bounce due to style (I'll re-run it before I land, but the change looks good so far).

swab.c(libc): use a simplified version of byte swapping

pushed

bsdinstall/distfetch.c: check environment variables before downloading and handle memory allocation errors

landed.

bsdinstall/distfetch.c: check environment variables before downloading and handle memory allocation errors

I backed this out after pushing. I'd somehow gotten the impression that @jrtc27 's objections had been addressed, but I was mistaken. Also looking at it critically, it fails our...

bsd.prog.mk: Link with --fatal-warnings like bsd.lib.mk

Looks good to me as well

bsd.prog.mk: Link with --fatal-warnings like bsd.lib.mk

So what's the status here? Seems like this should just be closed since it was a testing PR, but maybe I'm missing something

bsd.prog.mk: Link with --fatal-warnings like bsd.lib.mk

Ok marking in progress until then...

bsd.prog.mk: Link with --fatal-warnings like bsd.lib.mk

@jrtc27 any status update?

bsd.prog.mk: Link with --fatal-warnings like bsd.lib.mk

> > @jrtc27 any status update? > > Not yet, but I'm starting to drain my backlog of TODOs, as you may have seen from my recent revivals of old...