Warner Losh comments

Results 449 comments of


                                            Warner Losh

Fix typos

This pull request is now outside of our policy: We generally have stopped accepting typos in comments via pull request. However, it's otherwise almost perfect, so I'll land it. Next...

read.2 - resolved a self-reference link in manual page

Looks good now. @bsdbcr can you give me a final sanity check on the advice here?

read.2 - resolved a self-reference link in manual page

So this needs to be curated a bit. The last two commits add nothing since one reverts the other, so should be dropped. and I think that the other commits...

Perfer sys/cdefs.h __unreachable over the builtin

Landed this... go ahead and start to implement the c23 defined macro if you can do it w/o problems on older C compilers.

Perfer sys/cdefs.h __unreachable over the builtin

OK, automation still bad, but I caught it this time.

{cut,diff,head,join,patch,xargs}: use getline() instead of fgetln()

So these changes look good. I'm none-the-less nervous about them. What is the useage of the altenrative bsd tools that you pointed me to? Have you run the kyua tests...

{cut,diff,head,join,patch,xargs}: use getline() instead of fgetln()

> > Have you run the kyua tests on these programs before/after to make sure that there's no subtle regressions? > > I had assumed the CI would run this,...

{cut,diff,head,join,patch,xargs}: use getline() instead of fgetln()

ci run results: all specific tests in /usr/tests/usr.sbin/{head,cut,diff,patch,join,xargs} pass

{cut,diff,head,join,patch,xargs}: use getline() instead of fgetln()

5fbdcd65fe5c pushed

cu.1: describe better + tag spdx

"call unix over a serial line" maybe?