Warner Losh
Warner Losh
So the code itself does match the rather non-FreeBSD-ish style that these are written in. It assumes that these files are mmapable and seekable, but that's no different in practice...
@VexedUXR Can you commit or close? I think we should do this before 15.
Note: I missed rylish's review, my apologies.
short term NAK on this (leave the PR open). We need to be careful about namespace pollution and I'd like to start marking those glibc extensions that are likely going...
> No worries. I'll leave it open. These values are under '#if __BSD_VISIBLE || __XSI_VISIBLE' along with the non-long double constants. The diff on GitHub isn't large enough to show...
I'll merge this, but Add the _XSI_VISISBLE change, though we have a long ways to go for full 800 support.
merged with the change I requested.
@asomers I think we do one final pint to @jrtc27 and commit if there's no reply in a couple of days.
Is this ready to go into stable/14? We dont' normally do pull requests for MFCs, but this might be a good exception.