Warner Losh
Warner Losh
I've noticed 2 real differences so far (the other differences are comments or sorting deltas): We have `#define nosys linux_nosys` added to the linux files. what is this done? It...
OK. That's this round. It looks to be mostly style. I'll test it on the next round to see if I can find some issues I'm not seeing in glancing...
Also, the 3rd-5th commit messages need to have more descriptive titles. They are a little generic. Let me know if you want more specific suggestions.
Other than a couple of very minor style nits, the only thing I see is the strdup/refactoring suggestion I made.
Oh no. Gotta review this. Missed it when it came in
Landing this, after fixing the conflict.
Generally, I like this. I'm unsure of what we should do by default...
Oh cool! I'll bump the priority of getting back to this then and making sure we have this feature, though maybe not this API (but if I can't come up...