Warner Losh comments

Results 449 comments of


                                            Warner Losh

bsd.prog.mk: Link with --fatal-warnings like bsd.lib.mk

I'm cleaning up the pull requests... I'm going to close it. You can resubmit or reopen when you have time.

if_bridge: avoid process non-local targeted packages via pf

@kprovost Can you take another look? I'd like to either merge or close this and it looks stalled.

if_bridge: avoid process non-local targeted packages via pf

closing for now. This has stalled, has remaining objections and needs some more work. If that situation changed, please create a new pull request.. Thanks!

arm/allwinner: simple-framebuffer on A20 and Olimex-SOM-EVB support

I've tagged this as changes-required because it's not suitable in its current form, though I'm not at all clear which changes we'll need. It might also be invalid (per make...

arm/allwinner: simple-framebuffer on A20 and Olimex-SOM-EVB support

This has been changes requested for a couple months now. I'm going to close it as inactive. If you revisit this, please feel free to reopen this pull request, or...

less: Do not trust st_size if it equals zero

Specifically, should we import, or just cherry-pick the patch...

less: Do not trust st_size if it equals zero

This isn't in v643, but is in v653 (https://github.com/gwsw/less/commit/1fafd968b48e5cea6c85f126d77071a8de707a55 shows it there), but isn't in the release notes. v653 is in beta testing right now, so once it's official, @delphij...

units.c: decrease strlen() calls and use else if in lookupunit() function

I think this change is correct, but I'm not 100% sure.

units.c: decrease strlen() calls and use else if in lookupunit() function

(1) seems too churny to not fix a specific problem. While that was oK when you submitted this, we've recently updated our policy to disallow it when there's not a...

Remove repeated words

OK. There's a fix to a message, so I'll not just close this under the new policy, but also merge it. But going forward...