Warner Losh comments

Results 449 comments of


                                            Warner Losh

typo in contrib/bearssl/src/hash/ghash_pclmul.c

I'm going to close this, we'll get it with the next bearssl import and don't need to keep it open.

ctags: Use C99 bool instead of defining our own

I'd match the existing style, so don't change the returns. The GETC stuff is a weird macro, and it's just a false positive, so it's good.

ctags: Use C99 bool instead of defining our own

I think this is ready. I'll try to land it later today.

typo on contrib/tcsh/ed.chared.c and contrib/traceroute/traceroute.c

I can land the tcpdump correction (we effectively don't have an upstream for it) But we're still pulling from tsch, so can you submit your typo to https://github.com/tcsh-org/tcsh instead please?...

typo on contrib/tcsh/ed.chared.c and contrib/traceroute/traceroute.c

We'll get these changes in the next tcsh upstream import

Apply libxo to a part of nvmecontrol

We'd need do document `--libxo` command line argument. Generally, we don't document the schema used, but maybe we should start. I don't want to gate this commit, though, on that.

Apply libxo to a part of nvmecontrol

appplogies for the delay. Do you get any warnings with --libxo:XPW or --libxo:JPW?

nmdm: Allow module to be force-unloaded.

@kevans91 Looks like this is ready for you to re-review since it looks like your feedback has been applied.

nmdm: Allow module to be force-unloaded.

any update?

nmdm: Allow module to be force-unloaded.

looks like changes are still needed... any upate?