Andrew Scott comments

Results 264 comments of


                                            Andrew Scott

fix(upgrade): Make zoneless work with hybrid apps

caretaker note: Please review this PR and merge

feat(Clock): Add ability to automatically tick the clock asynchronously

> I think I understand the problems this is meant to solve, but it's not clear to me how a user would use it to solve those problems. Could you...

feat(Clock): Add ability to automatically tick the clock asynchronously

As one example that seems reasonable for an app to test with fake timers, consider an input meant to be some instant search API. The search is debounced (using a...

feat(Clock): Add ability to automatically tick the clock asynchronously

Hi Steve, I’m definitely still interested but I’m on paternity leave until mid-January. Looking forward to working on this with you.

feat(Clock): Add ability to automatically tick the clock asynchronously

> If the idea is that auto tick mode should be in effect for the entire duration of the spec, then maybe the API should consist of just an `autoTick`...

feat(Clock): Add ability to automatically tick the clock asynchronously

> So if we ship something narrow that we know is useful, like clock.autoTick(), we can iterate on it by adding more methods later if the need arises ... >...

feat(Clock): Add ability to automatically tick the clock asynchronously

Okay, I've updated the public API to just have `clock.autoTick` with some additional documentation of why the API might be useful. The internals are still implemented in a way that...

feat(Clock): Add ability to automatically tick the clock asynchronously

Hi @sgravrock, we've discussed this some more and feel like the simple `autoTick()` API is sufficient. This should work well enough with `pausepoints`, with minor edge cases for tests that...

feat(Clock): Add ability to automatically tick the clock asynchronously

@sgravrock Awesome! Our repo is on the latest version of jasmine so I'm looking forward to the next release when this is available 🥳

feat(Clock): Add ability to automatically tick the clock asynchronously

`advanceUntilModeChanges` is an infinite loop and not meant to be awaited (it’d resolve only when the mode changes again). It’s async only because it’s easier to write with async/await but...