Andrew Scott
Andrew Scott
@michaelgriscom Great, thanks for helping out on the review here! I'll take one last look and run a global presubmit
[Green TGP](https://fusion2.corp.google.com/presubmit/tap/523131268/OCL:523131268:BASE:523114146:1681157726821:af722dc2/targets)
@fmalcher The schematics will be updated, but as a separate PR.
> What is wrong with class based guard and resolvers? Why are they deprecated? > > I have the impression some new architecture ideas are rushed and forced onto the...
> nit: this line looks a bit complex: > > ``` > const url = router.getCurrentNavigation()!.extractedUrl.toString(); > ``` > > I was thinking if we can replace it with something...
> I think that all folks who used to write a dead simple unit tests for class-based guards with dependencies (and passing them via constructor) will not be happy that...
Just dropping in to mention this is somewhat trivially solved by simply inheriting data both before and after calling the resolver here: https://github.com/angular/angular/blob/8cef5dd7c1c79f503671f2f196c754ce307a8a3b/packages/router/src/operators/resolve_data.ts#L52-L54 Some refactors can make this better such...
This PR was merged into the repository by commit c8472e5e9e2cfc9cdfbdb0d8ca0254b2f7b4f287.
This PR was merged into the repository by commit 2c0e60eceb4cc0e5e531801bc4e76b3f18b11ffc.
This PR was merged into the repository by commit 53b0d6adb838705755ba7e260e7ff5c824c84d85.