Alberto Soragna

Results 248 comments of Alberto Soragna

* Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=17220)](http://ci.ros2.org/job/ci_linux/17220/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=11763)](http://ci.ros2.org/job/ci_linux-aarch64/11763/) * Windows [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_windows&build=17680)](http://ci.ros2.org/job/ci_windows/17680/)

Hi, are there any more changes that we should address before proceeding with this PR? I see that there are some failures in windows tests, are these known problems?

Changes look good to me, I just left some minor comments. New CI * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=17374)](http://ci.ros2.org/job/ci_linux/17374/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=11908)](http://ci.ros2.org/job/ci_linux-aarch64/11908/) * Windows [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_windows&build=17876)](http://ci.ros2.org/job/ci_windows/17876/)

My bad! I copied the repos file in the wrong field..! New CI * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=17377)](http://ci.ros2.org/job/ci_linux/17377/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=11911)](http://ci.ros2.org/job/ci_linux-aarch64/11911/) * Windows [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_windows&build=17879)](http://ci.ros2.org/job/ci_windows/17879/)

Hi, anything else to address before merging this PR?

@fujitatomoya @iuhilnehc-ynos is there anything else we should address before merging this PR?

New CI * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=17687)](http://ci.ros2.org/job/ci_linux/17687/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=12233)](http://ci.ros2.org/job/ci_linux-aarch64/12233/) * Windows [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_windows&build=18277)](http://ci.ros2.org/job/ci_windows/18277/)

The windows failure happens also in a completely unrelated PR https://github.com/ros2/rclcpp/pull/1979

Running full CI. The github check reports failures on rclcpp tests but they seem unrelated. * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=17754)](http://ci.ros2.org/job/ci_linux/17754/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=12296)](http://ci.ros2.org/job/ci_linux-aarch64/12296/) * Windows [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_windows&build=18400)](http://ci.ros2.org/job/ci_windows/18400/)

Ping; can we merge this PR?