Alberto Soragna
Alberto Soragna
* Linux [](http://ci.ros2.org/job/ci_linux/17220/) * Linux-aarch64 [](http://ci.ros2.org/job/ci_linux-aarch64/11763/) * Windows [](http://ci.ros2.org/job/ci_windows/17680/)
Hi, are there any more changes that we should address before proceeding with this PR? I see that there are some failures in windows tests, are these known problems?
Changes look good to me, I just left some minor comments. New CI * Linux [](http://ci.ros2.org/job/ci_linux/17374/) * Linux-aarch64 [](http://ci.ros2.org/job/ci_linux-aarch64/11908/) * Windows [](http://ci.ros2.org/job/ci_windows/17876/)
My bad! I copied the repos file in the wrong field..! New CI * Linux [](http://ci.ros2.org/job/ci_linux/17377/) * Linux-aarch64 [](http://ci.ros2.org/job/ci_linux-aarch64/11911/) * Windows [](http://ci.ros2.org/job/ci_windows/17879/)
Hi, anything else to address before merging this PR?
@fujitatomoya @iuhilnehc-ynos is there anything else we should address before merging this PR?
New CI * Linux [](http://ci.ros2.org/job/ci_linux/17687/) * Linux-aarch64 [](http://ci.ros2.org/job/ci_linux-aarch64/12233/) * Windows [](http://ci.ros2.org/job/ci_windows/18277/)
The windows failure happens also in a completely unrelated PR https://github.com/ros2/rclcpp/pull/1979
Running full CI. The github check reports failures on rclcpp tests but they seem unrelated. * Linux [](http://ci.ros2.org/job/ci_linux/17754/) * Linux-aarch64 [](http://ci.ros2.org/job/ci_linux-aarch64/12296/) * Windows [](http://ci.ros2.org/job/ci_windows/18400/)
Ping; can we merge this PR?