Alberto Soragna

Results 248 comments of Alberto Soragna

Looks good to me. Full CI including your rcl PR * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=17204)](http://ci.ros2.org/job/ci_linux/17204/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=11747)](http://ci.ros2.org/job/ci_linux-aarch64/11747/) * Windows [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_windows&build=17630)](http://ci.ros2.org/job/ci_windows/17630/)

I like the overall idea. However I have a couple of questions from looking at your examples. It seems like there are multiple methods to retrieve each interface (e.g. `base`...

Looks good to me. I left a couple of minor comments about style. CI: * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=17631)](http://ci.ros2.org/job/ci_linux/17631/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=12179)](http://ci.ros2.org/job/ci_linux-aarch64/12179/) * Windows [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_windows&build=18206)](http://ci.ros2.org/job/ci_windows/18206/)

IMO a feature like this can be easily implement via a wrapper around the `Timer` class (and this is also how I would recommend to implement it, without modifying the...

Considering that multiple developers agree on this feature, I'm ok with integrating it. However, I also think that the ros core should pay attention to the zero overhead principle, as...

CI * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=16370)](http://ci.ros2.org/job/ci_linux/16370/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=10979)](http://ci.ros2.org/job/ci_linux-aarch64/10979/) * Windows [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_windows&build=16737)](http://ci.ros2.org/job/ci_windows/16737/)

CI * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=16377)](http://ci.ros2.org/job/ci_linux/16377/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=10986)](http://ci.ros2.org/job/ci_linux-aarch64/10986/) * Windows [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_windows&build=16749)](http://ci.ros2.org/job/ci_windows/16749/)

CI * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=16387)](http://ci.ros2.org/job/ci_linux/16387/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=10996)](http://ci.ros2.org/job/ci_linux-aarch64/10996/) * Windows [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_windows&build=16759)](http://ci.ros2.org/job/ci_windows/16759/)

New CI with updated cyclonedds * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=16395)](http://ci.ros2.org/job/ci_linux/16395/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=11004)](http://ci.ros2.org/job/ci_linux-aarch64/11004/) * Windows [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_windows&build=16767)](http://ci.ros2.org/job/ci_windows/16767/)

CI * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=16404)](http://ci.ros2.org/job/ci_linux/16404/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=11015)](http://ci.ros2.org/job/ci_linux-aarch64/11015/) * Windows [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_windows&build=16776)](http://ci.ros2.org/job/ci_windows/16776/)