Alberto Soragna

Results 248 comments of Alberto Soragna

@wjwwood @clalancette @audrow @hidmic @ivanpauno can we get a review? this PR has been open for more than 1 year

Hi @DensoADAS, this is a 1-year old PR and it looks like it has been completely rebased and/or reworked. It will require a full review from scratch before proceeding. I'll...

Sorry for the wait. CI build: * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=19845)](http://ci.ros2.org/job/ci_linux/19845/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=14343)](http://ci.ros2.org/job/ci_linux-aarch64/14343/) * Windows [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_windows&build=20566)](http://ci.ros2.org/job/ci_windows/20566/)

The PR looks good. If possible, I would ask to add a few more unit-tests to validate the changes in the intra-process manager

CI with repos https://gist.github.com/alsora/2cb20dc394c9722625b409f4a8566c5f * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=18667)](http://ci.ros2.org/job/ci_linux/18667/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=13195)](http://ci.ros2.org/job/ci_linux-aarch64/13195/) * Windows [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_windows&build=19396)](http://ci.ros2.org/job/ci_windows/19396/)

Running again as the failure seems unrelated. * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=18685)](http://ci.ros2.org/job/ci_linux/18685/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=13211)](http://ci.ros2.org/job/ci_linux-aarch64/13211/) * Windows [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_windows&build=19413)](http://ci.ros2.org/job/ci_windows/19413/)