Feature/ipm with rclcpp serialized messages
Enabling publishing rclcpp::SerializedMessage for IPM (rcl_serialized_message_t are not supported for IPM).
Generic publisher can be created now with rclcpp::Publisherrclcpp::SerializedMessage. Therefore GenericPublisher is not needed anymore.
uses changes from: https://github.com/ros2/rclcpp/pull/1928
updated to review
I think I processed all comments
while testing I found two bugs which I fixed
@alsora are further steps required from us? thank you
What is missing for approval? Thank you :smile:
Hi @DensoADAS, this is a 1-year old PR and it looks like it has been completely rebased and/or reworked. It will require a full review from scratch before proceeding.
I'll try to do it this week.
Hi @DensoADAS, this is a 1-year old PR and it looks like it has been completely rebased and/or reworked. It will require a full review from scratch before proceeding.
I'll try to do it this week.
@alsora Did you have already time for the review? Thank you.
Hi @DensoADAS, this is a 1-year old PR and it looks like it has been completely rebased and/or reworked. It will require a full review from scratch before proceeding.
I'll try to do it this week.
any updates?
@ivanpauno @hidmic @wjwwood
Could someone also review the code? Thank you
Any updates from the reviewers?
rebased
The PR looks good. If possible, I would ask to add a few more unit-tests to validate the changes in the intra-process manager
I will add some unit tests