rclcpp icon indicating copy to clipboard operation
rclcpp copied to clipboard

Feature/ipm with rclcpp serialized messages

Open DensoADAS opened this issue 3 years ago • 14 comments

Enabling publishing rclcpp::SerializedMessage for IPM (rcl_serialized_message_t are not supported for IPM).

Generic publisher can be created now with rclcpp::Publisherrclcpp::SerializedMessage. Therefore GenericPublisher is not needed anymore.

uses changes from: https://github.com/ros2/rclcpp/pull/1928

DensoADAS avatar May 17 '22 07:05 DensoADAS

updated to review

DensoADAS avatar Jun 22 '22 08:06 DensoADAS

I think I processed all comments

DensoADAS avatar Jun 27 '22 15:06 DensoADAS

while testing I found two bugs which I fixed

DensoADAS avatar Jul 07 '22 09:07 DensoADAS

@alsora are further steps required from us? thank you

DensoADAS avatar Jul 19 '22 12:07 DensoADAS

What is missing for approval? Thank you :smile:

DensoADAS avatar May 10 '23 06:05 DensoADAS

Hi @DensoADAS, this is a 1-year old PR and it looks like it has been completely rebased and/or reworked. It will require a full review from scratch before proceeding.

I'll try to do it this week.

alsora avatar May 22 '23 10:05 alsora

Hi @DensoADAS, this is a 1-year old PR and it looks like it has been completely rebased and/or reworked. It will require a full review from scratch before proceeding.

I'll try to do it this week.

@alsora Did you have already time for the review? Thank you.

DensoADAS avatar May 30 '23 05:05 DensoADAS

Hi @DensoADAS, this is a 1-year old PR and it looks like it has been completely rebased and/or reworked. It will require a full review from scratch before proceeding.

I'll try to do it this week.

any updates?

DensoADAS avatar Jun 12 '23 07:06 DensoADAS

@ivanpauno @hidmic @wjwwood

Could someone also review the code? Thank you

DensoADAS avatar Jun 22 '23 10:06 DensoADAS

Any updates from the reviewers?

DensoADAS avatar Oct 26 '23 08:10 DensoADAS

rebased

DensoADAS avatar Nov 13 '23 08:11 DensoADAS

Sorry for the wait. CI build:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

alsora avatar Nov 22 '23 17:11 alsora

The PR looks good. If possible, I would ask to add a few more unit-tests to validate the changes in the intra-process manager

alsora avatar Nov 22 '23 17:11 alsora

I will add some unit tests

DensoADAS avatar Dec 06 '23 12:12 DensoADAS