nodejs
v8,tools: expose experimental wasm revectorize feature
The wasm simd256 revectorization feature is enabled by default when v8_enable_webassembly is true on x64 target in V8. At runtime it will be enabled through flag --experimental-wasm-revectorize.
This PR adds the build configuration in Node to enable this feature and make it explicitly accessible through the same runtime flag for x64 build.
@targos Could you help me merge this PL? I seem not authorized and it's already one week passed. Thank you in advance!
Commit Queue failed
- Loading data for nodejs/node/pull/54896 ✔ Done loading data for nodejs/node/pull/54896 ----------------------------------- PR info ------------------------------------ Title v8,tools: expose experimental wasm revectorize feature (#54896) Author Yolanda-Chen <[email protected]> (@yolanda15, first-time contributor) Branch yolanda15:enable_revec -> nodejs:main Labels build, v8 engine, tools, needs-ci Commits 1 - v8,tools: expose experimental wasm revectorize feature Committers 1 - Yolanda Chen <[email protected]> PR-URL: https://github.com/nodejs/node/pull/54896 Reviewed-By: Michaël Zasso <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54896 Reviewed-By: Michaël Zasso <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 12 Sep 2024 07:48:42 GMT ✔ Approvals: 1 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/54896#pullrequestreview-2303482481 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10952384360
The test failure seems unrelated. Not wasm test and not reproducible locally. Rebased and rerun the test.
Seems all test passed. I'm still not authorized. Could anyone help merge this PR? Not sure if any other authority is needed. Thanks in advance!
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6265/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6265/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6265/
Thanks Marco! Rebased to avoid test failures.
I would recommend to not rebase, unless there are conflicts to fix: when you rebase, the PR requires a full CI re-run, while we can simply resume the failed test suite if you don't rebase.
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6270/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6270/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6270/
I would recommend to not rebase, unless there are conflicts to fix: when you rebase, the PR requires a full CI re-run, while we can simply resume the failed test suite if you don't rebase.
Thanks for the recommendation! Noted and will avoid the rebase next time. @aduh95
Added a new commit to disable revec on mac to avoid a bulid failure with clang13 on macOS. Please see failed log at https://ci.nodejs.org/job/node-test-commit-osx/nodes=osx11-x64/61922/consoleFull. The same file compiles on Linux with g++-12. @targos @jasnel Please help take a look. Thanks!
CI: https://ci.nodejs.org/job/node-test-pull-request/63453/
The test failure on node-test-commit-arm seems timeout:
21:16:03 not ok 4128 parallel/test-stream-readable-unpipe-resume 21:16:03 --- 21:16:03 duration_ms: 360064.83100 21:16:03 severity: fail 21:16:03 exitcode: -15 21:16:03 stack: |- 21:16:03 timeout 21:16:03 ...
May need a retest @aduh95. Thanks!