nodejs
deps: update libuv to 1.49.0
Added also a couple of commits to partially revert the changes that fixed https://github.com/advisories/GHSA-vr4q-vx84-9g5x, as it's no longer relevant now that the SQPOLL ring is disabled by default.
Refs: https://github.com/libuv/libuv/releases/tag/v1.49.0
/cc @tniessen
Codecov Report
Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
Project coverage is 88.40%. Comparing base (
82dab76) to head (c42ae7e). Report is 665 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/node_credentials.cc | 50.00% | 0 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #55114 +/- ##
==========================================
+ Coverage 88.39% 88.40% +0.01%
==========================================
Files 652 652
Lines 186777 186774 -3
Branches 36039 36036 -3
==========================================
+ Hits 165102 165122 +20
+ Misses 14929 14905 -24
- Partials 6746 6747 +1
| Files with missing lines | Coverage Δ | |
|---|---|---|
| src/node_credentials.cc | 68.14% <50.00%> (-2.55%) |
:arrow_down: |
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Only the es-module/test-wasm-web-api.js in smartos is failing:
16:27:54 not ok 340 es-module/test-wasm-web-api
16:27:54 ---
16:27:54 duration_ms: 205.83000
16:27:54 severity: fail
16:27:54 exitcode: 1
16:27:54 stack: |-
16:27:54 node:internal/deps/undici/undici:13185
16:27:54 Error.captureStackTrace(err);
16:27:54 ^
16:27:54
16:27:54 TypeError: fetch failed
16:27:54 at node:internal/deps/undici/undici:13185:13
16:27:54 at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
16:27:54 at async Promise.all (index 1)
16:27:54 at async /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos20-64/test/es-module/test-wasm-web-api.js:91:3 {
16:27:54 [cause]: Error: connect EINVAL 127.0.0.1:55286 - Local (undefined:undefined)
16:27:54 at internalConnect (node:net:1097:16)
16:27:54 at defaultTriggerAsyncIdScope (node:internal/async_hooks:464:18)
16:27:54 at node:net:1327:9
16:27:54 at process.processTicksAndRejections (node:internal/process/task_queues:85:11) {
16:27:54 errno: -22,
16:27:54 code: 'EINVAL',
16:27:54 syscall: 'connect',
16:27:54 address: '127.0.0.1',
16:27:54 port: 55286
16:27:54 }
16:27:54 }
16:27:54
16:27:54 Node.js v23.0.0-pre
Also, this PR should not be merged as it is, we'll need to release [email protected] yet
@santigimeno please do not use the request-ci label when there's already a run available: https://github.com/nodejs/node/blob/eda98728dae77146a4f0d2b2a0fea49fd4ed14e6/doc/contributing/collaborator-guide.md#L252-L257
@nodejs/build it seems build doesn't even start on windows (git error), but it takes more than 1h to run. Is something wrong?
@nodejs/build it seems build doesn't even start on windows (git error), but it takes more than 1h to run. Is something wrong?
https://github.com/nodejs/build/issues/3929
Adding blocked label so this doesn't get merged by accident, based on
Also, this PR should not be merged as it is, we'll need to release
[email protected]yet
Refs: https://github.com/libuv/libuv/issues/4571
Landed in b57977909a5e9435489a07f063c02cd61c15b810...f97865fab436fba24b46dad14435ec4b482243a2